Fix/multi day event rendering#367
Open
John-Swindell wants to merge 1 commit intomhss1:devfrom
Open
Conversation
5c6e095 to
09b02fc
Compare
09b02fc to
67b217a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue.
Render multi-day calendar events on every day they span
Month view grouped events only by the start day index, so an event running Mon through Thu appeared only on Monday. The grouping now iterates from the event start date through its end date and adds the event to each covered day, using UTC for all-day events (stored as midnight UTC by CalendarContract) to avoid timezone skew that made all-day events appear a day early for users west of UTC.
List view had the same flaw: groupBy keyed each event by its start day only. loadListEvents now expands each event into one entry per day it covers, sorting continuation days as midnight so the event floats to the top per the expected behavior.
Fixes #69, #116, #358
Type of change
Checklist:
devbranch