HmsMaps: Modify the Snapshot method#3200
Open
DaVinci9196 wants to merge 3 commits intomicrog:masterfrom
Open
Conversation
mar-v-in
approved these changes
Dec 23, 2025
mar-v-in
requested changes
Feb 11, 2026
|
|
||
| override fun snapshot(callback: ISnapshotReadyCallback, bitmap: IObjectWrapper?) = afterInitialize { | ||
| Log.d(TAG, "snapshot") | ||
| val hmsBitmap = bitmap.unwrap<Bitmap>() ?: return@afterInitialize |
Member
There was a problem hiding this comment.
You should not ignore bitmap if it's provided. Only if bitmap is null or its dimensions (width + height) don't actually match the map view dimensions, you can ignore it, otherwise for performance reason, please use the bitmap provided.
| Log.d(TAG, "taking snapshot now") | ||
| val hmsCallback = HuaweiMap.SnapshotReadyCallback { result -> runOnMainLooper { | ||
| Log.d(TAG, "take snapshot end. $result") | ||
| callback.onBitmapWrappedReady(ObjectWrapper.wrap(result)) |
Member
There was a problem hiding this comment.
Use of onBitmapReady or onBitmapWrappedReady depends on the client version code (provided in initV2 call). Only version codes >= 4000000 support onBitmapWrappedReady. Given that most apps are using those, always using onBitmapWrappedReady will likely work except for a few very old apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the snapshot method to return the bitmap correctly.
e.g. Timestamp Camera<com.jeyluta.timestampcamerafree>