Skip to content

Map DXGI HRESULTS to D3DERR HRESULTS so that d3d9 apps can react appropriately #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdwtanner merged 2 commits into from
Feb 23, 2026
Merged

Map DXGI HRESULTS to D3DERR HRESULTS so that d3d9 apps can react appropriately #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725c5d1
Map DXGI HRESULTS to D3DERR HRESULTS so that d3d9 apps can react appr…
vdwtanner Feb 21, 2026
be80173
use D3DDDIERR where we can
vdwtanner Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions include/9on12Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,26 @@ namespace D3D9on12
Value value;
};

//
// Translates DXGI error codes to their D3D9 equivalents so that the
// correct HRESULTs propagate to the D3D9 runtime. Non-DXGI codes pass
// through unchanged.
//
// Not an exhuastive list, but the ones most likely to be hit
//
inline HRESULT TranslateDxgiHrToD3D9(HRESULT hr)
{
switch (hr)
{
case DXGI_ERROR_DEVICE_REMOVED: return D3DDDIERR_DEVICEREMOVED;
case DXGI_ERROR_DEVICE_HUNG: return D3DERR_DEVICEHUNG;
case DXGI_ERROR_DEVICE_RESET: return D3DERR_DEVICELOST;
case DXGI_ERROR_DRIVER_INTERNAL_ERROR: return D3DERR_DRIVERINTERNALERROR;
case DXGI_ERROR_INVALID_CALL: return D3DERR_DRIVERINTERNALERROR; // This is a driver error from the app's perspective as it means that 9on12 made an invalid call
default: return hr;
}
}

#define D3D9on12_DDI_ENTRYPOINT_START(implemented) \
__pragma(warning(suppress:4127)) /* conditional is constant due to constant macro parameter(s) */ \
if((implemented) == false && RegistryConstants::g_cBreakOnMissingDDI) \
Expand Down Expand Up @@ -114,6 +134,7 @@ __pragma(warning(suppress:4127)) /* conditional is constant due to constant macr
{ \
EntryPointHr = E_OUTOFMEMORY; \
} \
EntryPointHr = TranslateDxgiHrToD3D9(EntryPointHr); \

#define D3D9on12_DDI_ENTRYPOINT_END_AND_RETURN_HR(hr) \
CLOSE_TRYCATCH_AND_STORE_HRESULT(hr) \
Expand Down
Loading