Merged
Conversation
This is only used when copying chroma planes, and incorrectly asserts when trying to copy the entire resource (source box is zeroed out, so it was failing the check for back == 1). Tests pass with the check removed.
jenatali
approved these changes
Mar 3, 2026
vdwtanner
added a commit
that referenced
this pull request
Apr 14, 2026
This is only used when copying chroma planes, and incorrectly asserts when trying to copy the entire resource (source box is zeroed out, so it was failing the check for back == 1). Tests pass with the check removed. (cherry picked from commit 76534ae) (cherry picked from commit c54de19051ead51814fbe4eba506a16bc0a46325)
vdwtanner
added a commit
that referenced
this pull request
Apr 14, 2026
…n-planar resources * Map DXGI HRESULTS to D3DERR/D3DDDIERR HRESULTS so that d3d9 apps can react appropriately ([#102](#102) ) * Contain dxgi error code mapping fix * Remove debug assert in ConvertBoxToRect ([#103](#103)) * Contain debug assert fix * Use tighter packing for non-planar resources ([#105](#105)) * Contain tighter packing for non-planar resources change Backport bug: https://microsoft.visualstudio.com/OS/_workitems/edit/61561225/ ---- #### AI description (iteration 1) #### PR Classification This pull request implements an API enhancement by optimizing non-planar resource packing and improving DXGI error code translation for D3D9. #### PR Summary The changes introduce a feature-flag-controlled tighter packing strategy in resource memory layout and add a new inline function to map DXGI error codes to their D3D9 counterparts, ensuring more efficient error handling and resource management. - **`src/9on12Resource.cpp`**: Implements tighter packing for non-planar resources by recalculating row pitches and total size when the feature is enabled. - **`include/9on12Util.h`**: Adds the `TranslateDxgiHrToD3D9` function and updates error handling macros to use a cached feature flag for efficient DXGI error translation. - **`src/9on12Blit.cpp`**: Adjusts the box-to-rectangle conversion check to conditionally bypass strict validations based on the feature flag. - **`src/CMakeLists.txt` & `include/pch.h`**: Update build dependencies and include directories to support the new feature integration. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only used when copying chroma planes, and incorrectly asserts when trying to copy the entire resource (source box is zeroed out, so it was failing the check for back == 1). Tests pass with the check removed.