doc: Update URL in pointers to F.16 C++ Core Guidelines#1232
Merged
carsonRadtke merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
doc: Update URL in pointers to F.16 C++ Core Guidelines#1232carsonRadtke merged 1 commit intomicrosoft:mainfrom
carsonRadtke merged 1 commit intomicrosoft:mainfrom
Conversation
The anchor ID in the target is now lower-case.
Member
|
Thanks for making these changes; it should help folks correlate GSL docs with literature in the Guidelines. It looks like maybe this PR was the culprit: isocpp/CppCoreGuidelines#2304 and a lot more links might be broken in the README? I'll create an issue shortly, but feel free to take a stab at those if you want. Ideally, we would have a script that goes and validates all these links that we run in CI; I'd love to review a PR that accomplishes that! |
carsonRadtke
approved these changes
Mar 18, 2026
Contributor
Author
|
Ok, I see. This one should be the only fix needed inside the source code. I can take a look at the markdown next. Maybe in a follow-up pull? |
Member
|
FYI - #1233 was just created; if you want it, please comment on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anchor ID in the target is now lower-case.
This will save future code readers half a minute (or so) having to figure out the new anchor themselves every time they follow the link.