You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
Detailed Description of the Pull Request / Additional comments
When the user previews a midi file with peek, it will parse the midi file to get the positions, durations and pitches of musical notes, and plot them into a svg graph, where the X axis represents time, the Y axis represents pitch, and different colors represents different tracks. It will be shown in a webview2 where user can zoom and scroll.
Thanks oxygen dioxide (@oxygen-dioxide) for the PR.
Since we use WebView2 for preview, we’re considering whether it would be simpler to create a miniView.html with a well-known JavaScript bundle that handles MIDI well, rather than implementing most of the logic in C#. This would also be the preferred direction for adding new file types.
Thanks oxygen dioxide (@oxygen-dioxide) for the PR. Since we use WebView2 for preview, we’re considering whether it would be simpler to create a miniView.html with a well-known JavaScript bundle that handles MIDI well, rather than implementing most of the logic in C#. This would also be the preferred direction for adding new file types.
oxygen dioxide (@oxygen-dioxide) I agree with Gordon Lam (@yeelam-gordon); we want to keep Peek as light-weight as possible and would ideally like to use WebView2 to be the renderer of certain file previews so we don't need to maintain a lot.
I'm therefore closing this PR. We do very much appreciate the work - and thanks for taking the time! If we can support you in porting some of these things to the WebView2 approach please let us know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
After this PR, users can preview midi (
.mid) files as piano roll with peek.PR Checklist
Detailed Description of the Pull Request / Additional comments
When the user previews a midi file with peek, it will parse the midi file to get the positions, durations and pitches of musical notes, and plot them into a svg graph, where the X axis represents time, the Y axis represents pitch, and different colors represents different tracks. It will be shown in a webview2 where user can zoom and scroll.
Validation Steps Performed
Download this file and extract:
Oh_My_Darling_Clementine.mid.zip
Launch powertoys. Turn on peek. press Ctrl+Space on the midi file, and peek will show a window like this: