format: we need to include the last byte#5977
Closed
SiliconA-Z wants to merge 1 commit intomicrosoft:mainfrom
Closed
format: we need to include the last byte#5977SiliconA-Z wants to merge 1 commit intomicrosoft:mainfrom
SiliconA-Z wants to merge 1 commit intomicrosoft:mainfrom
Conversation
We skip the last byte, which I guess happens to work for us, but is still improper. Also use int because unsigned char is bad for ARM64 and cannot exceed the value of an unsigned char anyway.
SiliconA-Z
force-pushed
the
off-by-one
branch
from
5b3d02e to
c657917
Compare
Contributor
|
You already opened #5942. Why do you create this PR, which fixes the same problem in a different way? |
Member
|
Yes, can you please explain what's going on here? Additionally, we will need test coverage that actually exercises this fix. PRs are challenging to review when they're dropped on our doorstep with little explanation or context. We want to welcome PRs but we really need more info. |
Member
|
This does seem to address a real bug, according to |
Member
|
Superseded by #6059, thanks @cpplearner. |
github-project-automation
bot
moved this from Work In Progress
to Done
in STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We skip the last byte, which I guess happens to work for us, but is still improper.