[api] Add GenericType type - #64190
Open
Tom Mrazauskas (mrazauskas) wants to merge 1 commit into
Open
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Tom Mrazauskas (mrazauskas)
September 7, 2026 17:27
View session
| } | ||
|
|
||
| /** Generic types */ | ||
| export type GenericType = InterfaceType & TypeReference; |
Contributor
Author
There was a problem hiding this comment.
The exact type definition in Strada is:
interface GenericType extends InterfaceType, TypeReference {
}
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The API additions are consistent across both variants and have targeted test coverage.
Pull request overview
Adds the missing GenericType API type and exposes generic targets through TypeReference.getTarget().
Changes:
- Adds and exports
GenericTypein synchronous and asynchronous APIs. - Narrows
getTarget()return types accordingly. - Tests access to generic target type parameters.
File summaries
| File | Description |
|---|---|
packages/typescript/src/api/async/types.ts |
Defines GenericType and updates getTarget(). |
packages/typescript/src/api/async/api.ts |
Exports GenericType. |
packages/typescript/src/api/sync/types.ts |
Adds generated synchronous type definitions. |
packages/typescript/src/api/sync/api.ts |
Adds generated synchronous export. |
packages/typescript/test/async/api.test.ts |
Tests asynchronous generic target parameters. |
packages/typescript/test/sync/api.test.ts |
Tests synchronous generic target parameters. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64189
This PR adds the missing
GenericTypetype.