Open
Conversation
dthaler
reviewed
Feb 20, 2026
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
….com/saxena-anurag/ebpf-for-windows-1 into user/anusa/custom_map_implementation
dthaler
reviewed
Feb 20, 2026
Collaborator
dthaler
left a comment
dthaler
left a comment
There was a problem hiding this comment.
Looks good. Just some nits in comments and SAL annotations.
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
previously approved these changes
Feb 21, 2026
Collaborator
dthaler
left a comment
dthaler
left a comment
There was a problem hiding this comment.
Looks good modulo a few more nits.
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
previously approved these changes
Feb 22, 2026
Alan-Jowett
reviewed
Feb 23, 2026
| bool | ||
| _sample_validate_client_map_data(_In_ const ebpf_map_client_data_t* client_data) | ||
| { | ||
| if (client_data->header.version != EBPF_MAP_CLIENT_DATA_CURRENT_VERSION && |
Member
There was a problem hiding this comment.
Possible logic bug? Should this be || not &&?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4375
This pull request introduces support for custom map types in eBPF extensions for Windows. It updates both the documentation and the extension API to describe and enable how extensions can implement and register new map types, alongside hooks and helper functions. The changes define new NPI contracts, data structures, and dispatch tables for map providers, and clarify how helper functions interact with custom maps.
Key changes:
Documentation updates for custom maps
New API and data structures for custom map providers
ebpf_extension.hto support custom map operations (create, delete, find, add, associate with program types, etc.) and epoch-based memory management. This includes theebpf_map_provider_data_t,ebpf_base_map_provider_dispatch_table_t, and related client-side structures and macros. [1] [2]NPI contract and GUID for map extensions
EBPF_MAP_INFO_EXTENSION_IID) inebpf_extension_uuids.hto uniquely identify the NPI contract for map information providers.These changes collectively enable eBPF extensions to define and register new map types, provide the necessary interfaces for the eBPF core to interact with custom maps, and document the requirements and procedures for extension authors.##
Testing
This PR adds tests.
Documentation
PR updates documentation.
Installation
NA.