Conversation
93876ba to
bd1233a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Microsoft LISA test suite to validate end-to-end kexec reboot behavior on Linux remote nodes, aiming to ensure a kernel-to-kernel reboot flow is working in deployed environments.
Changes:
- Introduces
KexecSuitewith an end-to-endverify_kexec_reboottest case. - Implements kexec tooling install checks, kernel/initrd discovery, kexec load/execute, reconnect logic, and post-reboot validation via a persisted marker file.
5b27b6d to
f3a1f5d
Compare
LiliDeng
reviewed
Feb 9, 2026
LiliDeng
reviewed
Feb 9, 2026
LiliDeng
reviewed
Feb 9, 2026
LiliDeng
reviewed
Feb 9, 2026
LiliDeng
reviewed
Feb 9, 2026
Implements end-to-end kexec functionality test that validates kernel-to-kernel reboot without firmware involvement. - Loads current kernel via kexec -l with matching initrd - Validates boot_id change and uptime reset after reboot - Auto-installs kexec-tools if missing - Multi-distro support (Ubuntu, RHEL, Debian, Azure Linux)
f3a1f5d to
9210f73
Compare
anirudhrb
requested changes
Feb 9, 2026
ed71f28 to
b6e5cb6
Compare
anirudhrb
requested changes
Feb 10, 2026
975d08d to
5112f02
Compare
anirudhrb
requested changes
Feb 12, 2026
5112f02 to
7ae15a5
Compare
anirudhrb
requested changes
Feb 13, 2026
Collaborator
anirudhrb
left a comment
There was a problem hiding this comment.
Mostly LGTM now! Just a few more comments and the serial console log collection implementation is pending.
2d690f5 to
eab6c58
Compare
anirudhrb
requested changes
Feb 16, 2026
eab6c58 to
9a5a77c
Compare
anirudhrb
requested changes
Feb 19, 2026
Collaborator
anirudhrb
left a comment
There was a problem hiding this comment.
Just one comment. Everything else is good to go!
- verify_kexec_reboot_systemd: Tests systemd integration path (systemctl kexec) - verify_kexec_reboot_direct: Tests raw kernel execution path (kexec -e) - Refactored _trigger_kexec_reboot to accept use_systemctl parameter - Removed fallback logic - each test case uses its own method exclusively - Removed unreliable dmesg check, kept journalctl for evidence (best effort) - Added SkippedException when systemctl not available for systemd test This addresses review feedback that kexec -e deserves its own test case and shouldn't be a fallback, allowing us to identify which integration path breaks when tests fail.
9a5a77c to
8681c9a
Compare
anirudhrb
approved these changes
Feb 20, 2026
LiliDeng
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements end-to-end kexec functionality test and validates end-to-end kexec reboot functionality and post-reboot system health.