Use license to specify MIT license instead of license-file in Cargo.toml#464
Merged
Conversation
Since Regorus is MIT-licensed, it would be better to specify `license = "MIT"` rather than using `licene-file` to point to the MIT license file.
Some tools do not support parsing of `license-file`, for example crates.io classifies Regorus' license as "non-standard":
$ curl -s https://crates.io/api/v1/crates/regorus/0.4.0 | jq .version.license
"non-standard"
Using `license` would provide better compatability with various tools.
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
anakrish
approved these changes
Aug 22, 2025
anakrish
left a comment
anakrish
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Rationale: The current license file specifies MIT and this change provides a better way to express the same license.
If there is a need to make it multi-license due to some code we are using, we could always move that code to a separate crate and have Regorus depend on it, retaining the MIT license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Regorus is MIT-licensed, it would be better to specify
license = "MIT"rather than usinglicene-fileto point to the MIT license file. Some tools don't support parsing oflicense-file, for example crates.io classifies Regorus' license as "non-standard":Using
licensewould provide better compatibility with various tools.There was a previous discussion regarding using multiple-licenses: https://github.com/microsoft/regorus/pull/105/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R6, @anakrish would be happy to hear your thoughts on whether using
licensewould be better here or if you still prefer keepinglicense-file.