Open
Conversation
Add 6 eval test cases for the lookup-schema skill covering: - Lookup of known definitions (SendActivity, OnRecognizedIntent, AdaptiveDialog) - Search command for model-related definitions - Resolve command for reference resolution - Negative test for graceful handling of non-existent definitions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add explicit UTF-8 encoding and error replacement to subprocess.run to prevent cp1252 codec failures on Windows. Also guard against None stdout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Hey @GiorgioUghini — the evals refactor in #130 changed the eval structure, so this will need a small update before merging:
The actual check types you're using ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first eval test suite for the
lookup-schemaskill — a reference/query skill that looks up Copilot Studio YAML schema definitions using three commands:lookup,search, andresolve.Since this is a stdout-based skill (no YAML files created), all checks use
stdout_contains,stdout_not_contains, andexit_code.Test Cases
lookupSendActivity,text, andkind.lookupintentandtriggerconcepts.lookupbeginDialogandtriggerare described.searchmodelDescriptionandproperties(not just the generic word "model").resolveQuestionWithOptionswith its$refsub-definitions. Verifies fully resolved output includesproperties.lookup(negative)FakeNonExistentKind. Verifies the skill gracefully reports "not found" without crashes (ENOENT,stack trace,FATAL).Coverage
lookup,search,resolve)basic-agentfixture (consistent with other eval suites)