bump versions for next-* pylint/pyright/mypy #9276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:python
Contributor
|
All changed packages have been documented.
|
commit: |
Collaborator
|
You can try these changes here
|
l0lawrence
commented
Dec 31, 2025
| # too-many-lines: Due to code generation many files end up with too many lines. | ||
| # Let's black deal with bad-continuation | ||
| disable=missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,disallowed-name,consider-using-max-builtin,unknown-option-value,file-needs-copyright-header | ||
| disable=missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,disallowed-name,consider-using-max-builtin,unknown-option-value,file-needs-copyright-header,use-maxsplit-arg,too-many-positional-arguments |
Member
Author
There was a problem hiding this comment.
are these warnings we would want? we already have a positional argument check somewhere
Member
There was a problem hiding this comment.
Is there any issue thrown by the generated code if too-many-positional-arguments is not included in the pylintrc?
Member
Author
There was a problem hiding this comment.
yes there were, I tried setting the associated max-param value to 5 to match the other linter check we have and they still flagged - I can't find the run where it failed but I can remove ignore and see where it fails again?
l0lawrence
changed the title
l0lawrence
commented
Dec 31, 2025
|
|
||
| # is it optional? | ||
| try: | ||
| if any(a for a in annotation.__args__ if a == type(None)): # pyright: ignore |
Member
Author
There was a problem hiding this comment.
this is to workaround unidiomatic-typecheck
l0lawrence
requested review from
catalinaperalta,
lmazuel,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.