Skip to content

Preserve blob content-type on save in BlobContainerFS #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Preserve blob content-type on save in BlobContainerFS #1505

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
336bb5e
Initial plan
Copilot Apr 29, 2026
f2a29b3
fix: preserve blob content-type when saving files in BlobContainerFS
Copilot Apr 29, 2026
40b014e
fix: optimize writeFile to use single getProperties() call for existe…
Copilot Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/BlobContainerFS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,16 @@ export class BlobContainerFS implements vscode.FileSystemProvider {
const { blobClient } = await this.getBlobClients(uri, storageAccount, accountKey, credentials);
const { baseName } = this.parseUri(uri);

const exists = await blobClient.exists();
let existingProperties: BlobGetPropertiesResponse | undefined;
try {
existingProperties = await blobClient.getProperties();
} catch (error) {
if (parseError(error).errorType !== "404") {
throw error;
}
}
const exists = existingProperties !== undefined;

if (!options.create && !exists) {
throw vscode.FileSystemError.FileNotFound(uri);
} else if (options.create && !options.overwrite && exists) {
Expand All @@ -431,9 +440,10 @@ export class BlobContainerFS implements vscode.FileSystemProvider {
} else {
progress.report({ message: localize('creatingBlob', `Creating blob {0}...`, baseName) });
}

await blobClient.getBlockBlobClient().uploadData(content, {
blobHTTPHeaders: {
blobContentType: mime.getType(uri.path) || undefined
blobContentType: existingProperties?.contentType || mime.getType(uri.path) || undefined
}
});
});
Expand Down
Loading