Skip to content

chat - make signInWithAlternateScopes default#280355

Merged
bpasero merged 1 commit intomainfrom
ben/disciplinary-rabbit
Dec 1, 2025
Merged

chat - make signInWithAlternateScopes default#280355
bpasero merged 1 commit intomainfrom
ben/disciplinary-rabbit

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Dec 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 1, 2025 16:29
@bpasero bpasero enabled auto-merge (squash) December 1, 2025 16:29
@bpasero bpasero self-assigned this Dec 1, 2025
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Dec 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes signing in with alternate scopes the default behavior for chat authentication by reordering the provider scopes array and removing the experimental configuration flag.

Key Changes:

  • Removed the experimental chat.signInWithAlternateScopes configuration setting
  • Reordered providerScopes array to make the comprehensive scope set (read:user, user:email, repo, workflow) the default
  • Simplified sign-in logic to always use the first scope set in the array

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/services/chat/common/chatEntitlementService.ts Simplified signIn method by removing conditional logic for alternate scopes and directly using the first scope set
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Removed the experimental chat.signInWithAlternateScopes configuration setting
product.json Reordered providerScopes array to position the comprehensive scope set as the default (first element)

@bpasero bpasero merged commit 23c5c4d into main Dec 1, 2025
33 of 34 checks passed
@bpasero bpasero deleted the ben/disciplinary-rabbit branch December 1, 2025 17:05
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants