refactor(devtools): make use of root level css variable.#127
Open
Kinbaum wants to merge 3 commits intomidday-ai:mainfrom
Open
refactor(devtools): make use of root level css variable.#127Kinbaum wants to merge 3 commits intomidday-ai:mainfrom
Kinbaum wants to merge 3 commits intomidday-ai:mainfrom
Conversation
|
@Kinbaum is attempting to deploy a commit to the Pontus Abrahamsson's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@pontusab Can I get your review on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced state-driven panel resizing with CSS custom properties set on the root HTML element. This decouples sizing from React state, lets CSS handle layout changes when the devtools panel moves or resizes, and provides a smoother developer experience when iterating on our own UIs.
Usage
If I'm building an interface with shadcn sidebar for example, then I can add the following classNames to the
SidebarInsetNow my interface will automatically adjust based on the variable value. Solid DX win.