Add more PFMEA and Control Plan column aliases#6
Merged
Conversation
Extend the PFMEA and Control Plan header alias sets with common, unambiguous variants (Operation No / Op # / Process No, Severity Rating, Detection Method, Special Characteristics / Key Characteristic / Critical Characteristic, Control Technique / Measurement Technique, Out of Control Action, Step Description). Existing aliases and all behaviour are unchanged. Ambiguous tokens (control, method, description, number, id, status) are not added; "inspection/evaluation method" stay mapped to detection_method only. Adds parametrized alias tests + a no-regression check; missing required column still raises a clear ParseError. Scoring, matching, finding types and the Markdown/JSON output are untouched. Closes #2. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2 — broaden real-template header coverage.
Scope
PFMEA_ALIASESandCONTROL_PLAN_ALIASESinparsers/excel.pywith common, unambiguous variants:Operation No/Operation Number/Op Number/Op #/Process No/Step NoProcess Description/Step DescriptionSeverity RatingDetection MethodSpecial Characteristics/Key Characteristic/Critical CharacteristicControl Technique/Measurement TechniqueOut of Control ActionTests
ParseError.Limits (unchanged)
No ambiguous aliases (
control,method,description,number,id,status);inspection/evaluation methodstay mapped todetection_methodonly. No configurable mapping, no CSV, no change to scoring / matching / finding types / JSON schema.Checklist
ruff+pytestgreen (54 tests)Closes #2.