Issue 1097 : Enhancement: Introduce the LiteralQueryField#1125
Open
ngardon wants to merge 1 commit intomikependon:masterfrom
Open
Issue 1097 : Enhancement: Introduce the LiteralQueryField#1125ngardon wants to merge 1 commit intomikependon:masterfrom
ngardon wants to merge 1 commit intomikependon:masterfrom
Conversation
ngardon
changed the title
Owner
|
Nice implementation mate. Can you resolved the comments and we will merged this after that. Thanks for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1097
I was not sure as to exactly was expected, so I propose a very naive, hacky, implementation.
I am aware that is very low quality, but I didn't want to modify too much low level code without a prior discussion.
Please tell me what you think and where do you see the code go from there.