Conversation
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new mila run command that executes commands across multiple remote clusters in parallel. The command can either run on all clusters with active SSH connections (default) or on user-specified clusters.
Key changes:
- New
mila runcommand with parallel execution across multiple clusters - Automatic detection of active cluster SSH connections
- Rich console output showing results per cluster with color-coded success/failure indicators
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| milatools/cli/run.py | Core implementation of the run command with async execution, cluster detection, and formatted output |
| milatools/cli/commands.py | Integration of the new run subcommand into the CLI argument parser |
| tests/cli/test_run.py | Unit tests for the run command logic with mocked RemoteV2 instances |
| tests/integration/test_run.py | Integration tests that verify the command works with actual SSH connections |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mila_run_demo.mp4