Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support with a new "--type" parameter that can be set to either "zed" or "vscode" and defaults to "vscode" for backward compatibility.
This currently doesn't handle nodes with no internet. The way to handle this on Zed is to configure the remote to use '"upload_binary_over_ssh": true' in the config for that remote, but there doesn't seem to be a way to configure that from the command-line. Maybe we could edit the zed config for the project to add this option before connecting to it, but that seems clunky and possibly surprising for users. For now, if you set this in your config manually once, it should then work for subsequent connections.