Skip to content

Add ControlMaster/ControlPersist/ControlPath to Mila cluster SSH config entries#184

Merged
lebrice merged 3 commits intomasterfrom
copilot/add-ssh-config-options-mila-cluster
Mar 25, 2026
Merged

Add ControlMaster/ControlPersist/ControlPath to Mila cluster SSH config entries#184
lebrice merged 3 commits intomasterfrom
copilot/add-ssh-config-options-mila-cluster

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

  • Add **ssh_multiplexing_config to all four mila SSH entries in MILA_ENTRIES
  • Update test snapshot files for the new ControlMaster/ControlPath/ControlPersist fields
  • Fix test_fixes_overly_general_cn_entry to be Windows-compatible: the expected dict only includes control multiplexing keys on non-Windows platforms (since ssh_multiplexing_config is {} on Windows)
Original prompt

add the ControlMaster/ControlPersist/ControlParh ssh config options for the mila cluster login and compute nodes, not just for the DRAC clusters.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Add ControlMaster, ControlPersist, and ControlPath options for mila cluster Add ControlMaster/ControlPersist/ControlPath to Mila cluster SSH config entries Mar 23, 2026
Copilot AI requested a review from lebrice March 23, 2026 21:23
@lebrice lebrice marked this pull request as ready for review March 24, 2026 13:39
@lebrice
Copy link
Copy Markdown
Collaborator

lebrice commented Mar 24, 2026

@copilot some tests are failing on windows. Can you try to correct the tests, or add a pytest.xfail(sys.platform == "win32") mark (or similar) to the failing tests?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 24, 2026

@copilot some tests are failing on windows. Can you try to correct the tests, or add a pytest.xfail(sys.platform == "win32") mark (or similar) to the failing tests?

Fixed in 6241e51. The issue was that test_fixes_overly_general_cn_entry expected controlmaster/controlpath/controlpersist keys unconditionally, but on Windows ssh_multiplexing_config is an empty dict so those keys aren't added. The test now only includes those keys in the expected dict when not running on Windows.

Copilot AI requested a review from lebrice March 24, 2026 14:18
Copilot AI and others added 3 commits March 24, 2026 16:27
@lebrice lebrice force-pushed the copilot/add-ssh-config-options-mila-cluster branch from 6241e51 to 760c8f3 Compare March 24, 2026 20:27
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.93%. Comparing base (8573991) to head (760c8f3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   68.97%   68.93%   -0.04%     
==========================================
  Files          17       17              
  Lines        2540     2540              
==========================================
- Hits         1752     1751       -1     
- Misses        788      789       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lebrice lebrice merged commit 4b88598 into master Mar 25, 2026
18 checks passed
@lebrice lebrice deleted the copilot/add-ssh-config-options-mila-cluster branch March 25, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants