Skip to content

Use --command flag executable for VSCode extension sync in mila code#185

Open
Copilot wants to merge 2 commits intomasterfrom
copilot/use-command-flag-for-code
Open

Use --command flag executable for VSCode extension sync in mila code#185
Copilot wants to merge 2 commits intomasterfrom
copilot/use-command-flag-for-code

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

When mila code syncs VSCode extensions to a remote cluster, it was hard-coded to use code as the local executable regardless of the --command flag value. Users running code-insiders or a custom binary would have their extensions listed/installed using the wrong executable.

Changes

  • vscode_utils.py: Thread a new code_command: str | None = None parameter through:
    • sync_vscode_extensions_get_vscode_extensions (for reading source extensions)
    • sync_vscode_extensions_install_vscode_extensions_task_function (for installing to LocalV2 destinations)
    • Both ultimately pass code_command to _get_local_vscode_executable_path(), which already accepted it
  • code.py: Pass command (from --command flag) into sync_vscode_extensions as code_command

All new parameters default to None (falls back to get_code_command() / $MILATOOLS_CODE_COMMAND), preserving backward compatibility.

# Before: always used "code" (or $MILATOOLS_CODE_COMMAND) regardless of --command
sync_vscode_extensions(LocalV2(), [login_node])

# After: uses the executable specified via --command
sync_vscode_extensions(LocalV2(), [login_node], code_command=command)
Original prompt

in mila code, also use the executable from the --command flag to install vscode extensions. currently it is hard-coded to be code.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Update mila code to use command flag for installing extensions Use --command flag executable for VSCode extension sync in mila code Mar 23, 2026
Copilot AI requested a review from lebrice March 23, 2026 21:59
@lebrice lebrice marked this pull request as ready for review March 24, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants