Conversation
…tionError Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com> Agent-Logs-Url: https://github.com/mila-iqia/milatools/sessions/1a144516-a778-481c-8ec3-9f55c11ae102
Copilot
AI
changed the title
[WIP] Investigate integration test errors for code_v1
Add xfail marks to code_v1 integration tests failing with SSHConnectionError
Mar 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 74.62% 68.97% -5.66%
==========================================
Files 17 17
Lines 2345 2540 +195
==========================================
+ Hits 1750 1752 +2
- Misses 595 788 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lebrice
added a commit
that referenced
this pull request
Mar 25, 2026
* Revert "Add xfail marks to code_v1 integration tests failing with SSHConnectionError (#186)" This reverts commit 8573991. * Add an xfail for github CI on code_v1 tests Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Replace xfail with skipif for code_v1 tests in GitHub CI Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com> Agent-Logs-Url: https://github.com/mila-iqia/milatools/sessions/12ff51c5-d3c4-4dff-ba12-655fb64ee724 --------- Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_code_with_existing_job[*-code_v1]was consistently failing in CI withSSHConnectionError: Authentication timeout— the same known paramiko auth issue already handled elsewhere viaPARAMIKO_SSH_BANNER_BUG.Changes
tests/integration/test_code.pyPARAMIKO_SSH_BANNER_BUGfromtest_slurm_remote(already used intest_code_v1.py)use_v1=Trueparametrized case oftest_code_with_existing_jobviapytest.param:The
code_v1cases now report asxfailrather than hard failures, consistent with how the same paramiko issue is handled intest_slurm_remote.pyandtest_code_v1.py.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.