Skip to content

Fix issues in GitHub CI due to 2fa changes on Mila cluster#187

Merged
lebrice merged 3 commits intomasterfrom
fix_CI_2fa_issues
Mar 25, 2026
Merged

Fix issues in GitHub CI due to 2fa changes on Mila cluster#187
lebrice merged 3 commits intomasterfrom
fix_CI_2fa_issues

Conversation

@lebrice
Copy link
Copy Markdown
Collaborator

@lebrice lebrice commented Mar 24, 2026

  • Analyze the comment requesting skipif marks on code_v1 test variants
  • Replace xfail with skipif in test_code_v1.py (skips the test entirely in GitHub CI instead of marking as expected failure)
  • Add skipif marks to code_v1 parametrized variants in test_code.py's test_code_with_existing_job test

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

lebrice added 2 commits March 24, 2026 17:00
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Copy link
Copy Markdown
Collaborator Author

lebrice commented Mar 24, 2026

@copilot also add a skipif mark to the code_v1 test variants that are causing issues in the CI.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

@copilot also add a skipif mark to the code_v1 test variants that are causing issues in the CI.

Done in 95de615. Changed the xfail in test_code_v1.py to a skipif and added skipif marks to the code_v1 parametrized variant (use_v1=True) in test_code_with_existing_job in test_code.py, both skipping when in_github_CI is true.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.77%. Comparing base (8573991) to head (95de615).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   68.97%   68.77%   -0.20%     
==========================================
  Files          17       17              
  Lines        2540     2540              
==========================================
- Hits         1752     1747       -5     
- Misses        788      793       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lebrice lebrice merged commit 8ea572c into master Mar 25, 2026
18 checks passed
@lebrice lebrice deleted the fix_CI_2fa_issues branch March 25, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants