Skip to content

Add skipif mark to test_code_v1 in github CI#188

Closed
Copilot wants to merge 4 commits intomasterfrom
copilot/use-skip-mark-instead-of-xfail
Closed

Add skipif mark to test_code_v1 in github CI#188
Copilot wants to merge 4 commits intomasterfrom
copilot/use-skip-mark-instead-of-xfail

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

The test_code_v1 test was marked xfail on GitHub CI due to 2FA-related SSH failures on the Mila cluster. Since the test cannot run in that environment at all, skipif is more appropriate than xfail.

Changes

  • tests/integration/test_code_v1.py: Replace @pytest.mark.xfail(in_github_CI, raises=SSHConnectionError, ...) with @pytest.mark.skipif(in_github_CI, ...) — test is now skipped outright in GitHub CI rather than run and expected to fail
  • Remove the now-unused SSHConnectionError import
# Before
@pytest.mark.xfail(
    in_github_CI,
    raises=SSHConnectionError,
    reason="Misbehaving since the 2FA changes on the Mila cluster.",
)

# After
@pytest.mark.skipif(
    in_github_CI,
    reason="Misbehaving since the 2FA changes on the Mila cluster.",
)
Original prompt

use a skip mark instead of xfail (see the last commit for context)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

lebrice and others added 3 commits March 24, 2026 17:00
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Copilot AI changed the title [WIP] Update test logic to use skip mark instead of xfail Replace xfail with skipif for GitHub CI in test_code_v1 Mar 24, 2026
Copilot AI requested a review from lebrice March 24, 2026 21:51
@lebrice lebrice changed the title Replace xfail with skipif for GitHub CI in test_code_v1 Add skipif mark to test_code_v1 in github CI Mar 24, 2026
Base automatically changed from fix_CI_2fa_issues to master March 25, 2026 13:52
@lebrice lebrice closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants