Add skipif mark to test_code_v1 in github CI#188
Closed
Conversation
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com> Agent-Logs-Url: https://github.com/mila-iqia/milatools/sessions/af3a9121-762a-4762-8805-f2632dd16f60
Copilot
AI
changed the title
[WIP] Update test logic to use skip mark instead of xfail
Replace xfail with skipif for GitHub CI in test_code_v1
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_code_v1test was markedxfailon GitHub CI due to 2FA-related SSH failures on the Mila cluster. Since the test cannot run in that environment at all,skipifis more appropriate thanxfail.Changes
tests/integration/test_code_v1.py: Replace@pytest.mark.xfail(in_github_CI, raises=SSHConnectionError, ...)with@pytest.mark.skipif(in_github_CI, ...)— test is now skipped outright in GitHub CI rather than run and expected to failSSHConnectionErrorimportOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.