Conversation
Summary of ChangesHello @vgpopov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Helm chart for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Kubernetes support by refactoring how persistent volumes, especially for work and packages directories, are managed. It removes Google Batch-specific volume configurations and introduces a more generalized approach using persistence.workDir for shared storage. The changes include updates to Helm templates, values, and the schema definition. However, there are critical syntax errors in the newly added pvc-workstorage.yaml that need immediate attention, and an inconsistency in the docker schema definition.
| {{- if .Values.docker.enabled }} | ||
| {{- $dockerResources := fromYaml (include "platforma.dockerResources" .) }} | ||
| - "--runner-enable-docker" | ||
| - "--runner-local-cpu={{ include "platforma.parseCpuToWholeCpus" $dockerResources.limits.cpu }}" | ||
| - "--runner-local-ram={{ $dockerResources.limits.memory }}" | ||
| {{- end }} |
There was a problem hiding this comment.
The --runner-local-cpu and --runner-local-ram arguments are no longer being passed when docker.enabled is true. This removes the ability to configure CPU and RAM limits for the Docker runner via these arguments. Please confirm if this removal is intentional, or if these parameters are now configured through a different mechanism for Kubernetes support.
| "s3": { | ||
| "type": "object", | ||
| "additionalProperties": true, | ||
| "properties": { | ||
| "enabled": { "type": "boolean" } | ||
| "enabled": { | ||
| "type": "boolean" | ||
| } |
There was a problem hiding this comment.
The docker section has been removed from the values.schema.json. However, the docker configuration is still present in values.yaml and used in deployment-docker.yaml. Removing it from the schema will prevent proper validation of docker related values. Please ensure that the docker schema is retained if these values are still intended to be configurable.
| {{- if .Values.persistence.packagesDir.enabled -}} | ||
| {{- $_ := set $allPvcs "packages" .Values.persistence.packagesDir -}} | ||
| {{- end -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
The packagesDir configuration was removed from this block, implying it's now handled as a subdirectory of workDir. While this is reflected in deployment.yaml, the comment on line 70 only mentions workDir being handled separately. Consider updating the comment to clarify that packagesDir is also now managed as part of workDir's shared storage, or explicitly state its new handling.
For example, you could update the comment to: "Note: workDir and packagesDir are handled separately in deployment.yaml as they use shared NFS storage."
mike-ainsel
left a comment
mike-ainsel
left a comment
There was a problem hiding this comment.
# If your app needs to run as non-root
deployment:
podSecurityContext:
runAsUser: 1000
runAsGroup: 1000
fsGroup: 1000 # Won't affect Filestore, but good for other volumes
# Then on Filestore, ensure files are owned by UID 1000
# or use a Job/initContainer to fix permissions
If you need to change ownership on Filestore, use an init container running as root:
initContainers:
- name: fix-permissions
image: busybox
command: ['sh', '-c', 'chown -R 1000:1000 /data']
securityContext:
runAsUser: 0 # Run as root to change ownership
volumeMounts:
- name: filestore-volume
mountPath: /data
3 participants
No description provided.