Merged
Conversation
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 8ec4dc3 in 24 seconds
More details
- Looked at
188lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. go.mod:5
- Draft comment:
Thetoolchain go1.23.4directive is not standard and might cause compatibility issues. Consider removing it unless there's a specific need. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_s6Dg5dUmMQEz2JGA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2c36b57 in 12 seconds
More details
- Looked at
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/ci.yaml:18
- Draft comment:
Ensure that the codebase is compatible with Go 1.23, as the CI configuration now includes this version. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the Go versions in the CI workflow from 1.21 and 1.22 to 1.22 and 1.23. This is a straightforward update, but it's important to ensure that the codebase is compatible with the new Go versions. Additionally, the linter version is updated from v1.58 to v1.63, which should be checked for compatibility as well.
Workflow ID: wflow_GMYBEKGrJ3BnSVQg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update Go version and dependencies, including Gonum, in CI and project configuration files.
.github/workflows/ci.yamlfrom1.21, 1.22to1.22, 1.23.golangci-lintversion fromv1.58tov1.63.go.modto use Go1.22and toolchaingo1.23.4.gonum.org/v1/gonumtov0.15.1andgonum.org/v1/plottov0.14.0ingo.mod.go.modincludinggit.sr.ht/~sbinet/gg,github.com/go-fonts/liberation, andgithub.com/go-latex/latex.go.sumto reflect new dependency versions and checksums.This description was created by
for 2c36b57. It will automatically update as commits are pushed.