Skip to content

feat: add CI/CD workflows and self-update command#3

Merged
miltonparedes merged 6 commits intomainfrom
cli-workflow-improves
Mar 8, 2026
Merged

feat: add CI/CD workflows and self-update command#3
miltonparedes merged 6 commits intomainfrom
cli-workflow-improves

Conversation

@miltonparedes
Copy link
Copy Markdown
Owner

@miltonparedes miltonparedes commented Mar 7, 2026

@miltonparedes miltonparedes changed the title Cli workflow improves feat: add CI/CD workflows and self-update command Mar 7, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 11 additional findings in Devin Review.

Open in Devin Review

Comment thread cli/src/parser.ts
}

// ── Update has no flags — return early ──────────────────────
if (command === "update") return { type: "update" };
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 af update --agent <invalid> incorrectly rejects with 'invalidAgent' instead of running update

In parseCliArgs, the --agent flag is validated (lines 188-198) before the update early return (line 215). So running af update --agent badvalue returns { type: "invalidAgent" } instead of { type: "update" }. Since the update command explicitly ignores all flags (returning a bare { type: "update" }), agent validation should not apply to it. The same issue applies if a user runs af update -y -n --user — those flags are silently dropped by design, but --agent with an invalid value causes an error instead of being dropped.

Suggested change
if (command === "update") return { type: "update" };
// ── Update has no flags — return early ──────────────────────
if (command === "update") return { type: "update" };
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@miltonparedes miltonparedes merged commit 3aa2a0c into main Mar 8, 2026
2 checks passed
@miltonparedes miltonparedes deleted the cli-workflow-improves branch March 10, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant