mwdeploy: update gitinfo on --upgrade-{extensions,skins}

[RhinosF1]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The update changes the conditions in the run_process function of mwdeploy.py so that the version cache rebuild and gitinfo cache synchronization are now triggered not only when the option is 'world', but also when either args.upgrade_skins or args.upgrade_extensions is set. No public interfaces or function signatures were altered.

Changes

File(s)	Change Summary
modules/mediawiki/files/bin/mwdeploy.py	Expanded the conditional logic for triggering version cache rebuild and gitinfo cache synchronization.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant mwdeploy.py
    participant MediaWiki
    participant Rsync

    User->>mwdeploy.py: Invoke run_process(option, args)
    alt option == 'world' or args.upgrade_skins or args.upgrade_extensions
        mwdeploy.py->>MediaWiki: MirahezeMagic:RebuildVersionCache
        mwdeploy.py->>Rsync: Add gitinfo cache path to rsyncpaths
    end
    mwdeploy.py->>MediaWiki: Continue with deployment process

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8dd2a and a5719cb.

📒 Files selected for processing (1)

• modules/mediawiki/files/bin/mwdeploy.py (1 hunks)

🧰 Additional context used

🪛 Pylint (3.3.7)

modules/mediawiki/files/bin/mwdeploy.py

[error] 576-576: Possibly using variable 'runner_staging' before assignment

(E0606)

🔇 Additional comments (1)

modules/mediawiki/files/bin/mwdeploy.py (1)

568-577: I’ll verify the creation and use of runner_staging and the behavior of the option loop:

#!/bin/bash
set -e

# Locate mwdeploy.py in the repo
echo "mwdeploy.py path:"
fd mwdeploy.py

# Show creation of runner_staging around line 432
echo -e "\nLines 430–460 (runner_staging assignment):"
sed -n '430,460p' modules/mediawiki/files/bin/mwdeploy.py

# Show the per-version loop and the problematic block around lines 560–590
echo -e "\nLines 560–590 (for-option loop & runner_staging usage):"
sed -n '560,590p' modules/mediawiki/files/bin/mwdeploy.py

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Commit Unit Tests in branch RhinosF1-patch-1
• Post Copyable Unit Tests in Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RhinosF1]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.