Adds error handling for serialization failure in MPDB readRows#1030
Merged
jaredmixpanel merged 2 commits intomixpanel:masterfrom Feb 26, 2025
Merged
Adds error handling for serialization failure in MPDB readRows#1030jaredmixpanel merged 2 commits intomixpanel:masterfrom
jaredmixpanel merged 2 commits intomixpanel:masterfrom
Conversation
Contributor
Author
|
@jaredmixpanel Any chance of moving this forward? We got some counts of this crash in our crashlytics |
jaredmixpanel
approved these changes
Feb 26, 2025
Contributor
|
@pedro-nadolny Thanks for the PR. I will release a new version with this soon. |
Contributor
|
@pedro-nadolny |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issues reported in #1027
Without the error handling, serialization is returning nil and then trying to insert that in some array, which causes a crash.