Skip to content

chore: update dev dependencies#327

Merged
targos merged 1 commit intomainfrom
deps
Sep 12, 2025
Merged

chore: update dev dependencies#327
targos merged 1 commit intomainfrom
deps

Conversation

@targos
Copy link
Member

@targos targos commented Sep 12, 2025

No description provided.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (525db22) to head (c0e635e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   96.65%   96.66%           
=======================================
  Files         200      200           
  Lines        5923     5935   +12     
  Branches     1307     1307           
=======================================
+ Hits         5725     5737   +12     
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -59 to +60
const nbhd = Float64Array.from(adj[v]).sort();
const nbhd = Float64Array.from(adj[v]);
nbhd.sort();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mljs/collaborators I take the opportunity to show you this. The last release of the ESLint config adds a rule about sort(), similar to reverse() that we already have.
Note that the error message tells to use toSorted() and toReversed(), which sometimes is the right thing to do (for example to not modify the input), but there is another option: it is allowed to call .sort() and .reverse() like that as a statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the error only shows up when the return value of sort or reverse are assigned to something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly. The error shows up when the call is part of an expression. So another case for example is when you pass the return value directly to a function call: myFunction(arr.sort())

Copy link
Member

@stropitek stropitek Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that makes a lot of sense

@targos targos enabled auto-merge (squash) September 12, 2025 06:44
@targos targos merged commit 65d1c36 into main Sep 12, 2025
10 checks passed
@targos targos deleted the deps branch September 12, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants