Update Android parser for new Play Store format#1044
Open
imperador wants to merge 1 commit intommatyas:masterfrom
Open
Update Android parser for new Play Store format#1044imperador wants to merge 1 commit intommatyas:masterfrom
imperador wants to merge 1 commit intommatyas:masterfrom
Conversation
Updating AndroidAppsMetadata to parse newest Play Store format
mmatyas
requested changes
Mar 22, 2023
Owner
mmatyas
left a comment
mmatyas
left a comment
There was a problem hiding this comment.
Thanks! I've added some comments.
| , rx_background(QStringLiteral(R""(<meta property="og:image" content="(.+?)")"")) | ||
| , rx_developer(QStringLiteral(R""(<a href="/store\/apps\/dev(eloper)?\?id=.+?" class=".*?">([^<]+)<\/a><\/span>)"")) | ||
| , rx_category(QStringLiteral(R""(<a itemprop="genre".*?>([^<]+)<\/a>)"")) | ||
| , rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/([^"]+)" aria-label)"")) |
Owner
There was a problem hiding this comment.
It seems to me that the category href is uppercase; perhaps we could use the aria label instead? An example:
<a class="..." href="/store/apps/category/TOOLS" aria-label="Tools" jsname="...">
Contributor
Author
There was a problem hiding this comment.
That is a good approach. What about this then:
Suggested change
| , rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/([^"]+)" aria-label)"")) | |
| , rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/[^"]+" aria-label="(.*?)")"")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating AndroidAppsMetadata to parse latestPlay Store format