Skip to content

exporter: sanitize platform IDs in paths#6910

Open
tonistiigi wants to merge 1 commit into
moby:masterfrom
tonistiigi:platforms-id-sanitize
Open

exporter: sanitize platform IDs in paths#6910
tonistiigi wants to merge 1 commit into
moby:masterfrom
tonistiigi:platforms-id-sanitize

Conversation

@tonistiigi

Copy link
Copy Markdown
Member

Replace Windows path separators and drive separators when platform IDs are used as local and tar exporter path components. Add a regression test for tar exporter output generated from frontend-controlled platform metadata.

crazy-max
crazy-max previously approved these changes Jun 30, 2026
@crazy-max crazy-max dismissed their stale review June 30, 2026 10:20

failed test

@crazy-max

crazy-max commented Jun 30, 2026

Copy link
Copy Markdown
Member

This looks legit: https://github.com/moby/buildkit/actions/runs/28415832007/job/84256502530?pr=6910#step:8:290


=== FAIL: client TestIntegration/slice=3-4/TestExportTarPlatformIDSanitized/worker=containerd (1.22s)
    client_test.go:8170: 
        	Error Trace:	D:/a/buildkit/buildkit/client/client_test.go:8170
        	            				D:/a/buildkit/buildkit/util/testutil/integration/run.go:105
        	            				D:/a/buildkit/buildkit/util/testutil/integration/run.go:253
        	Error:      	Expected value not to be nil.
        	Test:       	TestIntegration/slice=3-4/TestExportTarPlatformIDSanitized/worker=containerd
        	Messages:   	expected sanitized tar path ".._buildkit-outside/payload.txt"

Replace Windows path separators and drive separators when platform IDs are
used as local and tar exporter path components. Add a regression test for tar
exporter output generated from frontend-controlled platform metadata.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the platforms-id-sanitize branch from 6f7a8ba to 77b65ab Compare July 3, 2026 00:25

@crazy-max crazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase to fix ci issue #6925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants