buildctl: ignore trace shutdown deadline#6918
Open
crazy-max wants to merge 1 commit into
Open
Conversation
crazy-max
force-pushed
the
fix-buildctl-trace-shutdown
branch
from
91d4be6 to
d145fae
Compare
crazy-max
force-pushed
the
fix-buildctl-trace-shutdown
branch
from
d145fae to
cd7a223
Compare
crazy-max
changed the title
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-buildctl-trace-shutdown
branch
from
cd7a223 to
cdda59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6912
Trace shutdown runs after the command action has already completed. The existing 50ms shutdown context can expire while the OpenTelemetry batch processor is flushing delegated spans over a slow connhelper transport.
Ignore only context deadline errors from tracer shutdown so telemetry cleanup cannot turn a successful command into a non-zero exit. Continue returning other tracer shutdown errors and existing app.After errors.