fix(filesystem): resolve symlinked allowed directories to both forms#3254
Open
wingding12 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
On macOS, /tmp is a symlink to /private/tmp. When users specify /tmp as an allowed directory, the server was resolving it to /private/tmp during startup but then rejecting paths like /tmp/file.txt because they dont start with /private/tmp. This fix stores BOTH the original normalized path AND the resolved path in allowedDirectories, so users can access files through either form. For example, with /tmp as allowed directory, both /tmp/file.txt and /private/tmp/file.txt will now be accepted. Fixes modelcontextprotocol#3253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3253
Problem
On macOS,
/tmpis a symlink to/private/tmp. When users specify/tmpas an allowed directory:/tmpto/private/tmpand stores only/private/tmpin allowedDirectories/tmp/file.txt, the initial validation check fails because/tmpdoesn't match/private/tmpSolution
Store both the original normalized path andthe resolved path in
allowedDirectories. This allows users to access files through either form:/tmp/file.txtmatches/tmpin allowedDirectories/private/tmp/file.txtmatches/private/tmpin allowedDirectoriesChanges
src/filesystem/index.ts: Modified allowed directory initialization to store both original and resolved paths when they differsrc/filesystem/__tests__/path-validation.test.ts: Added test for the symlink behaviorTests
Reproduction
Before fix:
npx -y @modelcontextprotocol/server-filesystem /tmp # Then request /tmp/test.txt -> REJECTEDAfter fix: