Fix wrong usage of quantities in Modelica.Electrical.Analog.Interfaces.IdealSemiconductor#4387
Merged
casella merged 2 commits intomodelica:masterfrom Aug 16, 2024
Merged
Conversation
AHaumer
added
bug
|
|
Contributor
Author
|
WTF ... I've signed the CLA long time ago. What's going wrong here? |
Member
beutlich
changed the title
Contributor
Author
|
I've used the same github user, just another notebook. No idea why the username is different and how I can sign the CLA with the other username because the two usernames are connected. |
HansOlsson
approved these changes
Apr 30, 2024
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Seems ok, but more stylistic improvement than bug-fix.
christiankral
approved these changes
May 12, 2024
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
This proposal is OK
…rmediateSwitch, ControlledIdealTwoWaySwitch, ControlledIdealIntermediateSwitch}
beutlich
force-pushed
the
IdealSemiconductor
branch
from
99c46d9 to
6156718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes bug #4386