Skip to content

Ensure that tests (via CTest) are built and run (CI)#4500

Merged
beutlich merged 1 commit intomodelica:masterfrom
beutlich:update-cmake-ci
Nov 12, 2024
Merged

Ensure that tests (via CTest) are built and run (CI)#4500
beutlich merged 1 commit intomodelica:masterfrom
beutlich:update-cmake-ci

Conversation

@beutlich
Copy link
Copy Markdown
Member

@beutlich beutlich commented Nov 5, 2024

No description provided.

@beutlich beutlich added the CI Issue that addresses continuous integration label Nov 5, 2024
@beutlich beutlich changed the title Ensure that tests (via CTest) are built and run Ensure that tests (via CTest) are built and run (CI) Nov 5, 2024
@beutlich beutlich added the V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases) label Nov 5, 2024
@casella
Copy link
Copy Markdown
Contributor

casella commented Nov 11, 2024

@beutlich what problem does this PR address? Any suggestion for reviewers?

@beutlich
Copy link
Copy Markdown
Member Author

beutlich commented Nov 11, 2024 •
edited
Loading

The ctest option --no-tests=error was added to not silently accept CI builds with -DBUILD_TESTING=OFF (ON is default) (which happened to me accidently when working on CMake configs of other reprositories I was contributing).

casella
casella approved these changes Nov 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casella casella requested a review from dietmarw November 11, 2024 21:35
@casella casella added this to the MSL4.2.0 milestone Nov 11, 2024
@casella casella requested a review from maltelenz November 11, 2024 21:35
maltelenz
maltelenz approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having any deeper insight into how CI is used in this project, this seems sensible, and I trust @beutlich to know what is needed.

@beutlich beutlich removed the request for review from dietmarw November 12, 2024 18:12
@beutlich beutlich merged commit 11a3981 into modelica:master Nov 12, 2024
@beutlich beutlich deleted the update-cmake-ci branch November 12, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltelenz maltelenz maltelenz approved these changes

@casella casella casella approved these changes

Assignees

No one assigned

Labels

CI Issue that addresses continuous integration V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases)

Projects

None yet

Milestone

MSL4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@beutlich @casella @maltelenz