Skip to content

Fix some sloppy lines on Blocks icons. - #4772

Merged
maltelenz merged 2 commits into
modelica:masterfrom
maltelenz:bugfix/sloppy-lines
Apr 13, 2026
Merged

Fix some sloppy lines on Blocks icons.#4772
maltelenz merged 2 commits into
modelica:masterfrom
maltelenz:bugfix/sloppy-lines

Conversation

@maltelenz

Copy link
Copy Markdown
Contributor

No description provided.

@AHaumer AHaumer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@AHaumer
AHaumer requested a review from tobolar April 10, 2026 17:44
@maltelenz
maltelenz enabled auto-merge April 13, 2026 06:33
@HansOlsson

Copy link
Copy Markdown
Contributor

The improvements for Modelica.Math.Exp and Power are not ideal yet.

Basically the x-axis is drawn in front of the line and for some weird reason using a Bezier-spline.

Comment thread Modelica/Blocks/Math.mo Outdated
Comment thread Modelica/Blocks/Math.mo
Comment thread Modelica/Blocks/Math.mo Outdated
@HansOlsson

Copy link
Copy Markdown
Contributor

Note that it may be the coordinate was changed from -80 to -80.39... instead of re-ordering the graphics, and with a proper order all of them could be -80 instead.

@HansOlsson HansOlsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative, but the proposed changes should be considered.
As noted it could be that the change from -80 to -80.3976 should be replaced by converting all of them to -80 instead (after re-ordering graphics).

@maltelenz
maltelenz force-pushed the bugfix/sloppy-lines branch from dfbae0f to 2ac074b Compare April 13, 2026 13:49
@maltelenz

Copy link
Copy Markdown
Contributor Author

@HansOlsson I tried applying your suggestions, but they were messed up somehow, I got a syntax error. I implemented what I think you meant in your comments from scratch, and force pushed with a new commit.

Please have a look.

@HansOlsson
HansOlsson self-requested a review April 13, 2026 14:53

@HansOlsson HansOlsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@maltelenz
maltelenz merged commit b05f26a into modelica:master Apr 13, 2026
2 checks passed
@maltelenz maltelenz added the L: Blocks Issue addresses Modelica.Blocks label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Blocks Issue addresses Modelica.Blocks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants