fix: update esbuild to 0.27.x#3005
Conversation
🦋 Changeset detectedLatest commit: db154e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43081j
force-pushed
the
esbuild-ranges
branch
from
c9c72b9 to
1e14f30
Compare
|
@43081j looks good to me, can you please fix conflicts? |
esbuild recently published a new major which means installs of WDS duplicate it currently, since we're bound to `0.25.0`. this just expands the semver range so we can de-dupe. Note this doesn't upgrade the locally installed esbuild (in this repo) as the storybook package uses storybook 8.x which still uses the older esbuild. So it means we would have 2 esbuild installs.
43081j
force-pushed
the
esbuild-ranges
branch
from
1e14f30 to
d304459
Compare
|
@bashmish rebased. in vite and others, they just bumped the version. i wonder if we should do the same here and drop the ranges? just require 0.27.x |
|
I'm fine either way. Only issue I see is that at some point we keep adding esbuild new version to the list and it becomes too much :) |
|
i think we should just bump it 👍 i have updated it note this means locally in the repo we have 2 esbuilds now until we upgrade storybook to 9.x or 10.x |
yeah, Storybook 9 is planned very soon, so shouldn't be an issue either |
bashmish
changed the title
.changeset/bright-toys-matter.md
Outdated
| '@web/storybook-builder': patch | ||
| --- | ||
|
|
||
| Expand esbuild semver to allow 0.26.0 and 0.27.0 |
2 participants
esbuild recently published a new major which means installs of WDS
duplicate it currently, since we're bound to
0.25.0. this just expandsthe semver range so we can de-dupe.
Note this doesn't upgrade the locally installed esbuild (in this repo)
as the storybook package uses storybook 8.x which still uses the older
esbuild. So it means we would have 2 esbuild installs.