Fix timestamp by keeping sctp layer#1
Open
kjh-wg2 wants to merge 1 commit intomoiji-mobile:masterfrom
Open
Conversation
zecke
reviewed
Jan 12, 2021
| for pkt in pcap: | ||
| ip = pkt['IP'] | ||
| layer = ip.payload | ||
| sctp = ip.payload |
There was a problem hiding this comment.
Shall we move this assignment to inside the layer.name == 'SCTP'?
zecke
reviewed
Jan 12, 2021
| sctp = ip.payload | ||
| while layer.name != 'NoPayload': | ||
| if layer.name == 'SCTP': | ||
| sport = layer.sport |
There was a problem hiding this comment.
I guess we can mostly remove this or replace this with sctp = layer and forget about sport/dport/tag? WDUT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the original timestamp of the SCTP layer to all the split up packets.