feat(compileRest): allow to reuse the rest settings, to generate rest path from parameters#336
Draft
thib3113 wants to merge 1 commit intomoleculerjs:masterfrom
Draft
feat(compileRest): allow to reuse the rest settings, to generate rest path from parameters#336thib3113 wants to merge 1 commit intomoleculerjs:masterfrom
thib3113 wants to merge 1 commit intomoleculerjs:masterfrom
Conversation
… path from parameters
Member
|
Good idea, please add relevant tests as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allow to call a endpoint to generate the rest url .
allow to do :
It can be usefull if you want to setup hypermedias, or just generate a link
I'm not sure about the naming, so I reuse the naming from
path-to-regexp"compile" .Not sure about the error throw if missing parameters, but it seems that path-regexp throw an error if a parameter is missing (I also tried with parameter
validateto false) .State of the PR :