this fixes typing issues for moeculer-web#357
Closed
fugufish wants to merge 1 commit intomoleculerjs:nextfrom
Closed
this fixes typing issues for moeculer-web#357fugufish wants to merge 1 commit intomoleculerjs:nextfrom
fugufish wants to merge 1 commit intomoleculerjs:nextfrom
Conversation
declare is typically used to enhance an existing type declaration for a module, as this is the actual module, a declare block actually breaks the typings
Author
|
The changes to the CHANGELOG.md were due to my markdown linter, I can revert that if you wish, it simpy adds spacing around the headers blocks. |
icebob
requested changes
Dec 4, 2024
Member
icebob
left a comment
icebob
left a comment
There was a problem hiding this comment.
Great job, thanks. Could you please update and resolve conflicts?
icebob-ai
pushed a commit
that referenced
this pull request
Mar 23, 2026
The `declare module "moleculer-web"` wrapper was incorrect since this is the module's own type definition file, not an ambient declaration. Removing it allows proper type inheritance and extension by consumers. Based on PR #357 by @atomstackjs, adapted for the next branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for identifying this issue! The |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declare is typically used to enhance an existing type declaration for a module, as this is the actual module, a declare block actually breaks the typings