wallet-rpc: deprecate payment_id from parse / make_uri#275
wallet-rpc: deprecate payment_id from parse / make_uri#275plowsof wants to merge 1 commit intomonero-project:masterfrom
Conversation
Note: The tx_payment_id parameter was supported in earlier versions of this specification but is now deprecated and no longer allowed for manual inclusion. https://github.com/monero-project/monero/wiki/URI-Formatting
|
| Example: | ||
|
|
||
| ```json | ||
| $ curl -X POST http://127.0.0.1:18088/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"parse_uri","params":{"uri":"monero:55LTR8KniP4LQGJSPtbYDacR7dz8RBFnsfAKMaMuwUNYX6aQbBcovzDPyrQF9KXF9tVU6Xk3K8no1BywnJX6GvZX8yJsXvt?tx_payment_id=420fa29b2d9a49f5&tx_amount=0.000000000010&recipient_name=el00ruobuob%20Stagenet%20wallet&tx_description=Testing%20out%20the%20make_uri%20function."}}' -H 'Content-Type: application/json' |
There was a problem hiding this comment.
with short payment id, i get
"message": "Error parsing URI: Invalid payment id: 50fa0ddf2e301fcf"
but with long payment id, i get
"uri": {
"address": "xxxxxxx",
"amount": 10,
"payment_id": "8a3ab856ac1f35eeacc9cc696b4901032fada3baa6caeaf9e70fb8b1447bc784",
"recipient_name": "el00ruobuob Stagenet wallet",
"tx_description": "Testing out the make_uri function."
There was a problem hiding this comment.
ah so this would be deprecating the short payment id in the example only?
the Note in the wiki is either wrong, or needs to clarify its only short id's , or this should not work but it does?
There was a problem hiding this comment.
or this should not work but it does?
this is how felt about it, but i have no idea
There was a problem hiding this comment.
after looking at make/parse uri functions spread across wallet2/api and rpc they still support it. im not sure what the best way would be to correct that if backwards compatibility is needed. a payment id == an integrated address iiuc which are still valid unless long payment ids are actually deprecated then it should not be backward compatible 🤔
2 participants
Note: The tx_payment_id parameter was supported in earlier versions of this specification but is now deprecated and no longer allowed for manual inclusion.
https://github.com/monero-project/monero/wiki/URI-Formatting