ringct: make h2d() fallible#10381
Open
jeffro256 wants to merge 1 commit intomonero-project:masterfrom
Open
Conversation
One theoretically could have crafted a "long amount" (pre-v10) RingCT transaction with non-0 padding bytes in the decoded amount which fails receiver scanning, but passes third-party wallet proof checking.
vtnerd
approved these changes
Apr 5, 2026
|
|
||
| #include <boost/lexical_cast.hpp> | ||
| #include "misc_log_ex.h" | ||
| extern "C" { |
Contributor
There was a problem hiding this comment.
Wish this was done in the header. :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One theoretically could have crafted a "long amount" (pre-v10) RingCT transaction with non-0 padding bytes in the decoded amount which fails receiver scanning (doesn't truncate decoded amount), but passes third-party wallet proof checking (does truncate decoded amount).