Skip to content

multisig: add flag to skip refresh after multisig import#10403

Open
woodser wants to merge 1 commit intomonero-project:masterfrom
woodser:import_refresh_master
Open

multisig: add flag to skip refresh after multisig import#10403
woodser wants to merge 1 commit intomonero-project:masterfrom
woodser:import_refresh_master

Conversation

@woodser
Copy link
Copy Markdown
Contributor

@woodser woodser commented Apr 5, 2026

Currently, import_multisig triggers an immediate, blocking refresh and rescan_spent after import.

On high-latency connections (e.g., Tor), this often causes the RPC call to hang or timeout while waiting for the scan to complete.

Furthermore, it prevents clients from using their own sync routines to report progress or sync in the background so the wallet is not blocked.

This PR adds an optional flag to import_multisig to decouple the data import from post-processing. This allows callers to ingest multisig data immediately and manage the subsequent resync on their own, providing a more responsive and transparent user experience.

Release PR: #10402

@woodser woodser force-pushed the import_refresh_master branch from 3935188 to 08c9aec Compare April 6, 2026 15:40
Copy link
Copy Markdown
Collaborator

@j-berman j-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok as a holdover until the following change is upstreamed: seraphis-migration@27db6ba

That change renders the refresh unnecessary.

I think we want to wait to upstream that commit until release v0.19 because release v0.19 is slated to trigger a wallet rescan for all wallets on load (so that wallets can sync the FCMP++ curve tree). If that commit is introduced to a v0.18 multisig wallet that has already identified received outputs but not yet called import_multisig for those outputs, then the wallet could enter a broken state without further changes (wallets pointing to untrusted daemons / GUI may miss when the outputs were spent). The wallet would need to re-sync from its restore height to avoid that state, which release v0.19 would do on load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants