Implement Ord for BinarySubtype

[tyilo]

I have the following type in my code that I would like to store in a BTreeMap:

enum BsonType {
    Double,
    String,
    Document,
    Array,
    Binary(BinarySubtype),
    Undefined,
    ObjectId,
    Boolean,
    DateTime,
    Null,
    RegularExpression,
    DbPointer,
    JavaScriptCode,
    Symbol,
    JavaScriptCodeWithScope,
    Int32,
    Timestamp,
    Int64,
    Decimal128,
    MinKey,
    MaxKey,
}

So I need to implement Ord for it. This is easier to do with this change.

[tyilo]

I don't think this works because UserDefined(123) != Reserved(123), but the compare equal with this Ord impl.

[tyilo]

I don't think this works because UserDefined(123) != Reserved(123), but the compare equal with this Ord impl.

I changed the PartialEq and Hash implementation so that Generic == UserDefined(0x00) == Reserved(0x00).

[abr-egn]

Seems reasonable enough to me.

Out of curiosity, your enum looks equivalent to ElementType except for the additional BinarySubtype value; can you share your use case for carrying the subtype along with that?

[tyilo]

Out of curiosity, your enum looks equivalent to ElementType except for the additional BinarySubtype value; can you share your use case for carrying the subtype along with that?

I use it to generate a schema from the documents in a MongoDB collection. I need the binary subtype to see if it is an UUID.