Skip to content

Composer: remove strict versioning of Sylius#9

Merged
maximehuran merged 6 commits intomonsieurbiz:2.xfrom
Kiwikoti:feature/remove-strict-versionning
Jul 15, 2025
Merged

Composer: remove strict versioning of Sylius#9
maximehuran merged 6 commits intomonsieurbiz:2.xfrom
Kiwikoti:feature/remove-strict-versionning

Conversation

@Kiwikoti
Copy link
Contributor

Allow installation of the plugin with version 2.1 of Sylius.

I think this change might ease the process of maintenance in the future.

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Jun 23, 2025
@maximehuran
Copy link

Hi @Kiwikoti,

Thank you for your contribution !

Can you check monsieurbiz/SyliusMediaManagerPlugin#29 and to the same changes to make the workflow green ?

@Kiwikoti
Copy link
Contributor Author

PR updated

@Kiwikoti
Copy link
Contributor Author

Kiwikoti commented Jul 2, 2025

Hey @maximehuran, just a ping to run the workflow when you have some time

cheers ✌️

@maximehuran
Copy link

@Kiwikoti
Can you fix the CI ?

Copy link

@maximehuran maximehuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the CI green ?

@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Needs review quick win Easy to pick, everybody will be happy. labels Jul 7, 2025
@Kiwikoti
Copy link
Contributor Author

@maximehuran I added a fix in phpstan.neon file to ignore the missingType.generics as it is done in other plugins like CmsPagePlugin or HomePagePlugins.

@Kiwikoti Kiwikoti requested a review from maximehuran July 15, 2025 13:57
@madamebiz madamebiz added Status: needs review Needs review and removed Status: needs update This Issue/PR needs update labels Jul 15, 2025
@maximehuran maximehuran merged commit 4c5850a into monsieurbiz:2.x Jul 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants