Skip to content

Added Intra Refresh Support#97

Open
TheElixZammuto wants to merge 3 commits intomoonlight-stream:masterfrom
TheElixZammuto:intra-refresh
Open

Added Intra Refresh Support#97
TheElixZammuto wants to merge 3 commits intomoonlight-stream:masterfrom
TheElixZammuto:intra-refresh

Conversation

@TheElixZammuto
Copy link
Copy Markdown
Contributor

This a companion PR on the moonlight-common-c project for these PR, the rationale/explanation for the PR can be found in the Sunshine one

Sunshine: LizardByte/Sunshine#3415
Moonlight-Xbox: TheElixZammuto/moonlight-xbox#155

Comment thread src/Limelight.h Outdated
Comment thread src/Limelight.h Outdated
@cgutman
Copy link
Copy Markdown
Member

cgutman commented Mar 27, 2025

@TheElixZammuto did you still want to get this merged or did you end up not needing it?

@TheElixZammuto TheElixZammuto requested a review from cgutman March 31, 2025 19:23
@TheElixZammuto
Copy link
Copy Markdown
Contributor Author

@cgutman FYI the patch is still needed, I'm using my fork currently, let me know if there are other points that needs to be addressed

@andygrundman
Copy link
Copy Markdown
Contributor

Yeah it would be good to merge this in, as it's a bit of a hassle to maintain an Xbox branch. I am curious if either of you have any ideas about how to improve on the unfortunate situation of Xbox intra refresh corruption. It happens most often on static or low-complexity content, and does resolve in a short time per the intra refresh settings, but it's just a bad experience. I tell people there's no solution, but is there anything we can do?

I couldn't work out why the Xbox decoder can't work with RFI, but it does crash if you try to enable it. I thought RFI might need changes to the render code around

	ctx->CopySubresourceRegion1(m_VideoTexture.Get(), 0, 0, 0, 0,
	                            (ID3D11Resource *)frame->data[0], (int)(intptr_t)frame->data[1],
	                            nullptr, D3D11_COPY_DISCARD);

so that ffmpeg had more buffers to use or something, but I didn't get very far trying to figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants