Create proxyOKLG.sol and edit supporting interface #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatl3y
requested changes
Apr 18, 2022
| //SPDX-License-Identifier: Unlicense | ||
| pragma solidity ^0.8.4; | ||
|
|
||
| import '@openzeppelin/contracts/token/ERC20/ERC20.sol'; |
Member
There was a problem hiding this comment.
Can we use the interface IERC20.sol here instead of the contract? will save on gas.
| address public OKLGStakingContract; | ||
| bool public factorNFTBoost = false; | ||
|
|
||
| modifier onlyOwner() { |
Member
There was a problem hiding this comment.
This is fine to specify the modifier, but we could use Ownable.sol as well to support the other functions like transferOwnership among other things in the future if need be.
| OKLGContract = _OKLGContract; | ||
| } | ||
|
|
||
| function setOKLGStakingContract(address _OKLGStakingContract) |
Member
There was a problem hiding this comment.
nitpick, but let's keep parameters camel case instead of title case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proxy contract can be used for the CollabLand bot in Discord to measure both normal and staked OKLG balance and optionally factor in NFT boosters