SkinnedMesh: Update "applyBoneTransform" to optionally take Vector4, support direction or position transformation#33091
Merged
gkjohnson merged 3 commits intomrdoob:devfrom Mar 1, 2026
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Feb 28, 2026
Mugen87
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
Previously there was no way to transform directions like vertex normals or tangents with SkinnedMesh. This PR updates the "applyBoneTransform" to take both a Vector3 or a Vector4. If a Vector3 is passed then it is assumed to be a position vector, as before. If a Vector4 is passed then homogenous coordinates can be used to treat it as either a direction (w === 0) or a position (w === 1).
Adjustment made for SkinnedMesh support in the path tracer.